IQSS-4760 update current version #5541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scolapasta
reviewed
Feb 21, 2019
| @@ -1989,6 +1995,53 @@ public String registerDataset() { | |||
| FacesContext.getCurrentInstance().addMessage(null, message); | |||
| return returnToDatasetOnly(); | |||
| } | |||
|
|
|||
| public String updateCurrentVersion() { | |||
There was a problem hiding this comment.
@qqmyers can you add comments here and in the api that this code is duplicated so that we know thatif a change occurs we would need to update in multiple places (until we move to an onSuccess)?
There was a problem hiding this comment.
added comments and brought the PR back up to date with dev...
scolapasta
approved these changes
Feb 27, 2019
This was referenced Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist